Fix text editing capabilities#96
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #96 +/- ##
==========================================
+ Coverage 73.17% 73.49% +0.32%
==========================================
Files 573 573
Lines 56342 56596 +254
==========================================
+ Hits 41229 41598 +369
+ Misses 15113 14998 -115
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request significantly improves the handling of empty paragraphs and caret/selection logic in the
StyledTextclass, especially around consecutive newlines and edge cases involving line navigation and caret positioning. It also introduces new APIs for line navigation and value retrieval in result types.Major improvements include:
StyledText caret and selection improvements
getGlyphIndexAtPositionto better handle clicks on empty lines and paragraphs, and to use a more robust line selection algorithm. [1] [2] [3]findParagraphNewlinePositionandfindParagraphNewlinePositionByIndex, to reliably map between visual lines/paragraphs and character indices for newlines. [1] [2]New API and navigation features
getGlyphIndexOnAdjacentLinefor moving the caret vertically between visual lines, treating soft-wrapped and explicit lines equivalently. [1] [2]ResultValue utility
valueOroverloads toResultValue, supporting both copy and move semantics for retrieving the stored value or a default, improving ergonomics when working with result types.